New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Rollup 2 #12010
chore: use Rollup 2 #12010
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27982/ |
I approved without noticing the failing build - why was the downgrade necessary? |
@@ -153,17 +152,13 @@ function buildRollup(packages) { | |||
// Rollup doesn't read export maps, so it loads the cjs fallback | |||
"packages/babel-compat-data/*.js", | |||
], | |||
namedExports: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namedExports
is removed per suggestions from @rollup/plugin-commonjs@13
.
Test fails on commonjs@14 and build fails on commonjs@15. I am preparing an upstream issue on build fails on commonjs@15. Before the upstream issue is resolved, let's pin commonjs to 13.0.2. |
const rollupNodeGlobals = require("rollup-plugin-node-globals"); | ||
const rollupNodeResolve = require("rollup-plugin-node-resolve"); | ||
const rollupReplace = require("rollup-plugin-replace"); | ||
const rollupNodePolyfills = require("rollup-plugin-node-polyfills"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollup-plugin-node-polyfills
replaces both rollup-plugin-node-globals
and rollup-plugin-node-builtins
. This has been done on v8 branch and now can be backported since we are not building on node.js 6.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f1fabb:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -27,7 +27,11 @@ | |||
"@babel/preset-flow": "^7.10.4", | |||
"@babel/register": "^7.10.5", | |||
"@babel/runtime": "^7.11.0", | |||
"@rollup/plugin-json": "4.0.1", | |||
"@rollup/plugin-babel": "^5.2.0", | |||
"@rollup/plugin-commonjs": "^13.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest commonjs
is 15, however I have to pin to 13 due to an upstream issue: rollup/plugins#557
Update to Rollup 2 and related plugins.